RFR: 8315362: NMT: summary diff reports threads count incorrectly [v4]
Evgeny Ignatenko
duke at openjdk.org
Tue Oct 10 13:46:34 UTC 2023
On Tue, 10 Oct 2023 13:38:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove bootclasspath from test
>
> Hi,
>
> Your new test fails, as the thread count is larger than expected (7 instead of 5). Have you run the test yourself? Since you're creating 5 threads inside of the main thread, I'd expect the thread count to be at least 6.
>
> The exact output is `(threads #36 +7)` and the error is `java.lang.RuntimeException: 'threads #\d+ +5' missing from stdout/stderr`
Hi @jdksjolen,
Ofcourse I run this test and it always passes for me. I am using macos-aarch platform.
Maybe it is not always correct to assume the amout of threads addede since VM could possible spawn some threads for it needs.
I guess that we could just check for thread ammout to be increased not assuming the exact amount of new threads then.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15490#issuecomment-1755458988
More information about the hotspot-runtime-dev
mailing list