RFR: 8317466: Enable interpreter oopMapCache for concurrent GCs [v2]
Zhengyu Gu
zgu at openjdk.org
Wed Oct 11 18:50:18 UTC 2023
On Wed, 11 Oct 2023 16:40:57 GMT, Leela Mohan Venati <duke at openjdk.org> wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cleanup old oop map cache entry after class redefinition
>
> src/hotspot/share/interpreter/oopMapCache.cpp line 506:
>
>> 504:
>> 505: if (Atomic::cmpxchg(&_array[i], entry, (OopMapCacheEntry*)nullptr, memory_order_relaxed) == entry) {
>> 506: enqueue_for_cleanup(entry);
>
> OopMapCache::flush_obsolete_entries() is called from VM_RedefineClasses::doit(). Enqueuing OopMapCacheEntries for cleanup means that we would need call OopMapCache::cleanup_old_entries() in VM_RedefineClasses::doit_epilogue()
Good catch. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16074#discussion_r1355594222
More information about the hotspot-runtime-dev
mailing list