RFR: 8316693: Simplify at-requires checkDockerSupport()

Mikhailo Seledtsov mseledtsov at openjdk.org
Thu Oct 12 16:32:34 UTC 2023


On Tue, 10 Oct 2023 00:06:12 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

> Please review this simple change.
> 
> Currently JTReg @requires extension test/jtreg-ext/requires/VMProps.java checkDockerSupport() uses "<CONTAINER_ENGINE> ps" command to check whether test host/environment allows for container testing. With this change proposing to switch it to "which <CONTAINER_ENGINE>":
>   - the "ps" command could be heavy-weight in some environments, taking longer time then expected
>   - it may not apply to all container engine types

Ioi, Leonid,
  Thank you for review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16111#issuecomment-1759957453


More information about the hotspot-runtime-dev mailing list