RFR: 8316693: Simplify at-requires checkDockerSupport()

Mikhailo Seledtsov mseledtsov at openjdk.org
Thu Oct 12 17:15:47 UTC 2023


On Thu, 12 Oct 2023 16:55:41 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> test/jtreg-ext/requires/VMProps.java line 607:
>> 
>>> 605:         ProcessBuilder pb = new ProcessBuilder("which", Container.ENGINE_COMMAND);
>>> 606:         Map<String, String> logFileNames =
>>> 607:             redirectOutputToLogFile("checkDockerSupport(): which <container-engine>",
>> 
>> Maybe it's better for the message to include the actual name of the engine?
>> 
>> 
>> redirectOutputToLogFile("checkDockerSupport(): which " + Container.ENGINE_COMMAND),
>
> I don't see how this comment was resolved. Did I miss something?

Sorry I missed this one. Filed: [JDK-8318029](https://bugs.openjdk.org/browse/JDK-8318029)
Minor improvement to logging output in container at-requires
Will address soon.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16111#discussion_r1357145576


More information about the hotspot-runtime-dev mailing list