RFR: 8315362: NMT: summary diff reports threads count incorrectly [v5]
Evgeny Ignatenko
duke at openjdk.org
Fri Oct 13 09:40:19 UTC 2023
On Tue, 10 Oct 2023 18:26:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Please hold off this patch (should not integrate before GHAs are green anyway), I want to look at this for a bit. We could possibly simplify this.
>
>> HI @tstuefe,
>>
>>
>>
>> Thank you for the feedback. I have already enabled GHA according to his instruction https://openjdk.org/guide/#github-actions (it was basically pressing one button) and it says that now some tier1 tests will run automatically on every push to the branch. I don't see if it is happening and I don't understand how should I launch it manually. I will take a look again, maybe I am missing some buttons at the interface.
>
> Yes, I think that should be it. A simple way to trigger new builds and tests is to synchronize the PR branch, or to merge master manually.
Hi @tstuefe!
I have reimplemented the patch according to your suggestions. I don't yet understand if GHA are working as they are supposed to, still trying to figure out. My local tests passes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15490#issuecomment-1761219734
More information about the hotspot-runtime-dev
mailing list