RFR: 8316967: Correct the scope of vmtimer in UnregisteredClasses::load_class [v2]
Jiangli Zhou
jiangli at openjdk.org
Fri Oct 13 22:03:07 UTC 2023
On Fri, 13 Oct 2023 16:37:35 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
> Thanks for the review and sorry for the delay in replying as I took a few days off.
> How about changing `ClassLoader::perf_sys_class_lookup_time()` to `ClassLoader::perf_app_class_lookup_time()`?
> Or simply using the existing `ClassLoader::perf_app_classload_time()`? (Which is being used in https://github.com/openjdk/jdk/blob/master/src/hotspot/share/classfile/systemDictionary.cpp#L1289-#L1299)
`ClassLoader::perf_app_classload_time` seems ok. If there is any interest in differentiating the class loading time for user defined classloader and archived cases, `perf_shared_unregistered_classload_time` might be more specific.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16046#issuecomment-1762297390
More information about the hotspot-runtime-dev
mailing list