RFR: 8315362: NMT: summary diff reports threads count incorrectly [v8]
Thomas Stuefe
stuefe at openjdk.org
Sun Oct 15 08:36:35 UTC 2023
On Sat, 14 Oct 2023 22:16:07 GMT, Evgeny Ignatenko <duke at openjdk.org> wrote:
>> 8315362: NMT: summary diff reports threads count incorrectly
>
> Evgeny Ignatenko has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments
All good, minus tests.
If you feel confident this builds and works on every platform, or if someone did tests for you (have not read the comments fully), feel free to integrate. The patch itself is fine.
But I still think its worth investing the time to understand why this fails, since I assume you plan on doing more contributions.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15490#pullrequestreview-1678752006
More information about the hotspot-runtime-dev
mailing list