RFR: JDK-8318089: Class space not marked as such with NMT when CDS is off

David Holmes dholmes at openjdk.org
Wed Oct 18 06:42:45 UTC 2023


On Fri, 13 Oct 2023 14:32:15 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> If Xshare is off, we don't correctly register class space with NMT. We should do that.

src/hotspot/share/memory/metaspace.cpp line 576:

> 574:   // operation and NMT seems not to be able to handle splits.
> 575:   // Will be fixed with JDK-8243535.
> 576:   // MemTracker::record_virtual_memory_type((address)rs.base(), mtClass);

So why not just uncomment this line, instead of moving this to the caller?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16184#discussion_r1363328419


More information about the hotspot-runtime-dev mailing list