RFR: 8318383: Remove duplicated checks in os::get_native_stack() in posix implementation

Thomas Stuefe stuefe at openjdk.org
Wed Oct 18 14:29:57 UTC 2023


On Wed, 18 Oct 2023 00:05:11 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Trivial cleanup that removes duplicated checkings.

Hi Zhengyu,

This is not trivial :)

let
A=> fp == null
B=> cb != null
C=> sender-pc == null
D=> is_first_frame

Old:
if (A || B || C || D) break;
if (!C && !D) get_sender_for...;

New:
if (A || B || C || D) break;
get_sender...

Not sure if that is correct, but it is at least not equivalent, so not a simple cleanup.

(note that I support any cleanup, the old code is terrible).

-------------

PR Review: https://git.openjdk.org/jdk/pull/16232#pullrequestreview-1685248683


More information about the hotspot-runtime-dev mailing list