RFR: 8317951: Refactor loading of zip library to help resolve JDK-8315220 [v2]

David Holmes dholmes at openjdk.org
Thu Oct 19 02:41:48 UTC 2023


On Wed, 18 Oct 2023 18:49:06 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This refactorization resolves the problem associated with [JDK-8315220](https://bugs.openjdk.org/browse/JDK-8315220) and, subsequently, [JDK-8315892](https://bugs.openjdk.org/browse/JDK-8315892).
>> 
>> Testing: jdk_jfr, tier1-9, stress testing
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update for review comments.

src/hotspot/share/utilities/zipLibrary.cpp line 152:

> 150: 
> 151: jzentry* ZipLibrary::find_entry(jzfile* zip, const char* name, jint* sizeP, jint* nameLen) {
> 152:   initialize();

Again don't we have to have initialized things to get the library we are now searching? The same goes for all(?) the other methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16149#discussion_r1364805680


More information about the hotspot-runtime-dev mailing list