RFR: 8317466: Enable interpreter oopMapCache for concurrent GCs [v2]

Leela Mohan Venati duke at openjdk.org
Thu Oct 19 16:14:20 UTC 2023


On Mon, 16 Oct 2023 20:03:44 GMT, Leela Mohan Venati <duke at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup old oop map cache entry after class redefinition
>
> src/hotspot/share/gc/shenandoah/shenandoahVMOperations.cpp line 64:
> 
>> 62:   OopMapCache::cleanup_old_entries();
>> 63: }
>> 64: 
> 
> Do you think, VM_ShenandoahFinalMarkStartEvac walks the stack roots.  If yes, i recommend adding OopMapCache::cleanup_old_entries() in  VM_ShenandoahOperation::doit_epilogue().  And this would make the change simple and also revert the change in this [PR](https://github.com/openjdk/jdk/pull/15921)

I stand corrected. 

My question is still relevant 
>> Do you think, VM_ShenandoahFinalMarkStartEvac walks the stack roots.

My recommendation is incorrect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16074#discussion_r1365804097


More information about the hotspot-runtime-dev mailing list