RFR: JDK-8314588: gc/metaspace/TestMetaspaceInitialization.java failed "assert(capacity_until_gc >= committed_bytes) failed: capacity_until_gc: 3145728 < committed_bytes: 3211264"

[Coleen Phillimore]

On Tue, 17 Oct 2023 10:40:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> See JBS issue text and comments.
> 
> I remove the assert that tests that the metaspace commit size has to be >= the GC threshold and make sure we don't overflow the subtraction.

Your explanation makes sense. So if some GC decides to shrink metaspace, decrements capacity_until_gc, we'll just return zero for allowed expansion and force the GC if until the number of committed bytes goes below that?  It seems like it might cause too many GCs.  I wonder if the code should be removed in the future, since what it does is odd.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16216#pullrequestreview-1690279475