RFR: 8317951: Refactor loading of zip library to help resolve JDK-8315220 [v2]

David Holmes dholmes at openjdk.org
Mon Oct 23 00:23:36 UTC 2023


On Fri, 20 Oct 2023 09:02:36 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Okay so if we have no control over the order in which functions are called then they all must initialize, including `close` - no?
>
> Close seems obvious, as you pointed out earlier, to be subsequent from open. An assert is there now, to capture erroneous usages, which I think is the correct way to capture wrong callers.
> 
> The complication comes with init_params() and compress() which are used in a jcmd heap dump routine, it does not open anything, it merely wants to re-use the logic of functions in the zip library.

Hmm okay. I found it hard to see exactly how this API actually gets exported for use.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16149#discussion_r1367999291


More information about the hotspot-runtime-dev mailing list