RFR: 8316814: NMT: A separate script or Java program is needed to analyze and make useful reports ouf of JMH benchmarks outputs. [v2]

Mon Oct 23 08:22:01 UTC 2023

On Mon, 23 Oct 2023 02:34:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Not a review but as per my comment in JBS I'm unclear where this tool really belongs. Perhaps @shipilev has an opinion?

As a reply to your comment, I moved the test to test/micro/bench/org/openjdk/bench/vm/runtime. It was already in ../bench/java/util. Maybe I misunderstood your comment.

> test/micro/org/openjdk/bench/vm/runtime/NMTAnalyze.java line 149:
> 
>> 147:       System.out.println(ioe.getMessage());
>> 148:     } finally {
>> 149:     }
> 
> This serves no purpose.

Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16070#issuecomment-1774664439
PR Review Comment: https://git.openjdk.org/jdk/pull/16070#discussion_r1368290023