Integrated: JDK-8318485: Narrow klass shift should be zero if encoding range extends to 0x1_0000_0000
Thomas Stuefe
stuefe at openjdk.org
Mon Oct 23 21:13:43 UTC 2023
On Thu, 19 Oct 2023 07:50:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> See JBS issue.
>
> The real fix, trivial, is the comparison change in compressedKlass.cpp.
>
> This patch then also adds a test that checks that for a given (forced) class space location the VM chose the correct encoding scheme. In this case, if class space nestles below and ends at 4G, we should use a shift of 0.
>
> The test can be easily extended to test more narrow Klass encoding schemes. Note that the test is skipped if the VM could not map at the expected address to begin with.
>
> Finally, to analyze test errors, I print out the mappings at the force address if metaspace logging is debug.
>
> Tests: manual, GHA. x86 GHA errors unrelated.
>
>
> Attention @iklam and @calvinccheung
This pull request has now been integrated.
Changeset: 5ba9705d
Author: Thomas Stuefe <stuefe at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/5ba9705d60fb3e3bab832aadd989b738471fcaf5
Stats: 110 lines in 6 files changed: 107 ins; 1 del; 2 mod
8318485: Narrow klass shift should be zero if encoding range extends to 0x1_0000_0000
Reviewed-by: ccheung, iklam
-------------
PR: https://git.openjdk.org/jdk/pull/16261
More information about the hotspot-runtime-dev
mailing list