RFR: 8318700: MacOS Zero cannot run gtests due to wrong JVM path

Aleksey Shipilev shade at openjdk.org
Tue Oct 24 10:30:37 UTC 2023


On Tue, 24 Oct 2023 10:11:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> See the bug for reproducer. The fix is easy: handle more JVM variants.
>
> src/hotspot/os/bsd/os_bsd.cpp line 206:
> 
>> 204: 
>> 205: // JVM variant
>> 206: #if   defined(ZERO)
> 
> Nit: extra spaces after if

This actually stacks up `defined(...)` cases. See the example in the block above it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16337#discussion_r1369941413


More information about the hotspot-runtime-dev mailing list