RFR: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm" [v4]
David Holmes
dholmes at openjdk.org
Wed Oct 25 22:15:00 UTC 2023
On Wed, 25 Oct 2023 13:38:04 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> The `attempt_allocate_memory_at(addr, size)` may fail for some reasons that `::mmap` will report. To find out why an attempt failed, an `int *` is passed down deep to the `::mmap` to return the `ERRNO` back to the callers.
>> This error code is used in gTest test case to show a proper message.
>>
>> The changed test case never failed after 10K+ repetitions, but in case it happens in future the reason is also printed out.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> remove extra parameter for windows and bsd versions.
Now this is a test-only change I have no comments. I'm not familiar enough with the test or tested API to review it.
-------------
PR Review: https://git.openjdk.org/jdk/pull/16240#pullrequestreview-1698327734
More information about the hotspot-runtime-dev
mailing list