RFR: 8317951: Refactor loading of zip library to help resolve JDK-8315220 [v4]

[David Holmes]

On Thu, 26 Oct 2023 10:01:55 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This refactorization resolves the problem associated with [JDK-8315220](https://bugs.openjdk.org/browse/JDK-8315220) and, subsequently, [JDK-8315892](https://bugs.openjdk.org/browse/JDK-8315892).
>> 
>> Testing: jdk_jfr, tier1-9, stress testing
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   do not exit vm on failure to resolve InitParams and Compress

So IIUC in the old code GZip_InitParam and GZip_Fully were lazily "resolved" at runtime and so no vm exit if anything went wrong. But now you are eagerly resolving them at the same time as all the other zip functions - which happens during VM init (or does it?**), so it would in fact make more sense to always do the vm_exit if something goes wrong.

** Now I'm not at all sure the initialization will in fact happen at VM init time, in which case VM exit is not the right thing to do.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16149#pullrequestreview-1699449857