RFR: JDK-8313781: Add regression tests for large page logging and user-facing error messages [v7]
David Holmes
dholmes at openjdk.org
Fri Oct 27 06:58:47 UTC 2023
On Mon, 23 Oct 2023 10:42:55 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> In preparation for the UseSHM removal (https://bugs.openjdk.org/browse/JDK-8310841) I'd like more regression tests.
>>
>> The new test basically checks the behavior of the JVM when confronted with different variations of:
>> - OS capabilities
>> - JVM settings.
>>
>> For example: If the JVM is started with -XX:+UseLargePages, but on the OS side there are no huge pages configured, or the kernel does not even support hugepages, the JVM should disable large pages and issue a warning.
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
> - Merge branch 'openjdk:master' into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
> - Merge branch 'openjdk:master' into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
> - Stefans suggestion
>
> Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
> - Stefans suggestion
>
> Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
> - Stefans suggestion
>
> Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
> - Merge branch 'JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages' of github.com:tstuefe/jdk into JDK-8313781-Add-regression-tests-for-large-page-logging-and-user-facing-error-messages
> - skip empties
>
> Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
> - Remove THPmode unknown
> - Several test fixes
> - ... and 2 more: https://git.openjdk.org/jdk/compare/953fc66d...3069eebb
Seems okay. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15159#pullrequestreview-1701104329
More information about the hotspot-runtime-dev
mailing list