RFR: 8317951: Refactor loading of zip library to help resolve JDK-8315220 [v4]

[Markus Grönlund]

On Mon, 30 Oct 2023 05:17:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Okay I finally understand. We used to initialize the entry points in two stages: one eager that would do VM exit if `dl_load` failed. The other two lazily with no vm-exit, or any error reporting. With the new code everything is initialized at once, but you extended the error handling to the individual `dll_lookup`s and so apply the vm-exit or not vm-exit to them based on earlier behaviour.
> 
> I can only assume that it is optional to have the Zip `InitParams`/`Fully` API's available so failing to find them is not fatal. A comment to that effect in `store_function_pointers` would clarify the initially strange seeming initialization logic. A future RFE could see if these truly are optional APIs, and if not simplify the code to treat everything consistently.
> 
> Thanks.

I added a comment.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16149#issuecomment-1785128093