RFR: 8317132: Prepare HotSpot for permissive- [v7]

Julian Waters jwaters at openjdk.org
Mon Oct 30 14:57:36 UTC 2023


On Mon, 30 Oct 2023 13:12:57 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains all of the fixes required for HotSpot to compile under the stricter mode activated when the permissive- flag is passed
>> 
>> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to avoid goto jumping across uninitialized locals
>> - Adds a CAST_FROM_FN_PTR cast to the return value from ::signal to void, as they cannot be implicitly converted
>> - symbolengine.cpp's SimpleBufferWithFallback's templates cannot work with a raw char (Actual fix under discussion)
>> - Removed a throw() specification from a mismatched definition in allocation.cpp
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Temporarily add permissive- to HotSpot flags in flags-cflags.m4

Just as I suspected, the '\0' is now required to be changed to 0 to compile in the initialize() method (for some weird reason, when it was compiling fine before)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15955#issuecomment-1785393975


More information about the hotspot-runtime-dev mailing list