RFR: 8307468: CDS Lambda Proxy classes are regenerated in dynamic dump

Calvin Cheung ccheung at openjdk.org
Fri Sep 1 23:57:40 UTC 2023


On Fri, 1 Sep 2023 20:28:07 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Please review this changeset for fixing the following issues:
>> 
>> 1. for lambda proxy classes already stored in the static archive, during CDS dynamic dump, those classes should not be regenerated and stored in the dynamic archive; (see changes in jvm.cpp)
>> 2. handle multiple lambda proxy classes with the same invoke dynamic info stored in both static and dynamic archives. (see changes in systemDictionaryShared.cpp)
>> 
>> Also added a test.
>> 
>> Passed tiers 1 - 4 testing.
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdasInTwoArchives.java line 88:
> 
>> 86:         // Note that the class list contains one less lambda proxy class comparing
>> 87:         // with running the LambdasWithSameKey app with the "run" argument.
>> 88:         String[] launchArgs  = {
> 
> Suggestion:
> 
>         String[] launchArgs = {

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15524#discussion_r1313645649


More information about the hotspot-runtime-dev mailing list