RFR: 8293850: need a largest_committed metric for each category of NMT's output

Johan Sjölen jsjolen at openjdk.org
Tue Sep 5 08:32:40 UTC 2023


On Wed, 16 Aug 2023 08:48:56 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> The `peak` amount of allocation is kept for Virtual Memory allocations.
> Whenever `reserved` and `committed` amounts are printed, the `largest_committed` also is printed.
> 
> tiers 1-7 passed.

LGTM, except there's a typo in `MemReportBase::print_total`'s output.

src/hotspot/share/services/memReporter.cpp line 58:

> 56:     amount_in_current_scale(reserved), scale, amount_in_current_scale(committed), scale);
> 57:   if (peak != 0) {
> 58:     output()->print(", largets_committed=" SIZE_FORMAT "%s", amount_in_current_scale(peak), scale);

`largets` => `largest`

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15305#pullrequestreview-1610509288
PR Review Comment: https://git.openjdk.org/jdk/pull/15305#discussion_r1315556006


More information about the hotspot-runtime-dev mailing list