RFR: 8314831: NMT tests ignore vm flags

[Gerard Ziemski]

On Wed, 6 Sep 2023 02:49:40 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

> Some NMT tests do not pass Java/JVM test command line options (flags) to the child process. Such tests should be examined and broken down into 2 categories:
>   - a test intentionally does not pass flags to child process - mark such tests with "@requires vm.flagless"
>   - tests did not pass flags to child process by mistake - fix them to use the right ProcessTools method that passes test flags to child process
> 
> For details see the JBS issue, including on how the tests were assigned to each category and the reasoning behind it.

The `ProcessTools.createJavaProcessBuilder()` -> `ProcessTools.createTestJvm()` change looks OK, but shouldn't we use `createJavaProcessBuilderIgnoreTestJavaOpts()` for those tests that do not want arguments passed, instead of tagging them with "@requires vm.flagless" or am I understanding the point of https://github.com/openjdk/jdk/pull/15452 incorrectly?

-------------

Changes requested by gziemski (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15576#pullrequestreview-1613666080