RFR: 8314831: NMT tests ignore vm flags
Gerard Ziemski
gziemski at openjdk.org
Wed Sep 6 20:28:42 UTC 2023
On Wed, 6 Sep 2023 17:51:44 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
> To answer a question from Gerard: shouldn't we use createJavaProcessBuilderIgnoreTestJavaOpts() ? A: even though MR for " 8315097: Rename createJavaProcessBuilder #15452 " is related in topic to this change, it is still under discussion and could take some time to make final decision on it. Once decision is done and change 15452 is approved, the global renaming will be applied.
>
> As far as tagging tests with "@requires vm.flagless" - this is our (HotSpot) recommended way of tagging tests that do not pass the JVM args to child VM. This is done in addition to using createJavaProcessBuilder(). This provides us a uniform way of knowing which tests do not pass flags to child VMs, we can make proper test selection when executing with flags based on that information.
I thought we may want to use 15452, but if we have to get this patch in now, then tweak it later a bit and you're OK with that, then so am I.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15576#issuecomment-1709053853
More information about the hotspot-runtime-dev
mailing list