RFR: 8315818: vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java fails on libgraal

[Tom Rodriguez]

On Wed, 6 Sep 2023 20:49:05 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR modifies eager JVMCI initialization such that a failure is logged but otherwise ignored if the initialization is solely for the purpose of `-Xcomp`.
> 
> This allows tests such as `vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java` to succeed on libgraal, even when there is insufficient virtual memory to mmap libgraal.

This seems a bit unsavory to me.  Why can't we set CompileBroker::_initialized to true in the same place that C2 does, but move the `comp->is_jvmci() && !JVMCI::can_initialize_JVMCI()` stuff to just after the `if (!_initialized || comp_level == CompLevel_none)` in CompileBroker::compile_method?  Wouldn't that give us early enough initialization for Xcomp while still complaining if we actually need a compilation but can't create the isolate?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15602#issuecomment-1709244499