RFR: 8315818: vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java fails on libgraal [v2]

Doug Simon dnsimon at openjdk.org
Thu Sep 7 11:01:16 UTC 2023


On Thu, 7 Sep 2023 10:55:36 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR modifies eager JVMCI initialization such that a failure is logged but otherwise ignored if the initialization is solely for the purpose of `-Xcomp`.
>> 
>> This allows tests such as `vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java` to succeed on libgraal, even when there is insufficient virtual memory to mmap libgraal.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instead of eagerly initializing JVMCI for -Xcomp, defer JVMCI compilations until JVMCI is initializable

src/hotspot/share/compiler/compileBroker.hpp line 304:

> 302:                                  CompileTask::CompileReason compile_reason,
> 303:                                  TRAPS);
> 304: private:

Making this helper method avoids anyone outside `CompileBroker` accidentally calling it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15602#discussion_r1318436173


More information about the hotspot-runtime-dev mailing list