RFR: 8315818: vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java fails on libgraal [v2]

[Doug Simon]

On Thu, 7 Sep 2023 18:54:29 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   instead of eagerly initializing JVMCI for -Xcomp, defer JVMCI compilations until JVMCI is initializable
>
> src/hotspot/share/jvmci/jvmci.cpp line 58:
> 
>> 56: void jvmci_vmStructs_init() NOT_DEBUG_RETURN;
>> 57: 
>> 58: bool JVMCI::can_initialize_JVMCI() {
> 
> For the non libgraal case is this test really complete?  I guess I'm not convinced that the tests in this method are sufficient the safe init point.  Maybe it would be simpler to have a `JVMCI::_can_be_initialized` flag which is set at the correct point during the init steps in the same way that `CompileBroker::_initialized` is set.  Having the order explicitly spelled out there seems better than trying to infer it from other state.

We've been running this code for a long time (Graal unit tests on jargraal, Native Image building of libgraal etc) so I don't see any reason to double-guess its correctness now. I suggest we leave it as is and address problems when/if they show up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15602#discussion_r1319012422