RFR: 8315795: runtime/Safepoint/TestAbortVMOnSafepointTimeout.java fails after JDK-8305507 [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Thu Sep 7 19:15:18 UTC 2023
On Thu, 7 Sep 2023 18:46:16 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address Dan's comments
>
> test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java line 71:
>
>> 69: "-XX:+SafepointALot",
>> 70: "-XX:+AbortVMOnSafepointTimeout",
>> 71: "-XX:AbortVMOnSafepointTimeoutDelay=10000",
>
> You should update:
>
> L33: * @bug 8219584 8227528
>
> to include this bug ID: 8315795.
>
> Also, you should add a comment explaining why the delay is now 10 seconds
> instead of 2.5 seconds. Something like:
>
> "-XX:AbortVMOnSafepointTimeoutDelay=10000", // Using 10 seconds instead of 2.5 seconds for windows-debug
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15622#discussion_r1319012741
More information about the hotspot-runtime-dev
mailing list