RFR: 8314832: Few runtime/os tests ignore vm flags [v2]

David Holmes dholmes at openjdk.org
Tue Sep 12 00:37:42 UTC 2023


On Mon, 11 Sep 2023 16:49:18 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> 8314832: Few runtime/os tests ignore vm flags
>
> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Addressing review feedback

I don't think we need to add flagless to the manual tests, but I'm not sure. I will leave it to you.

Thanks

test/hotspot/jtreg/runtime/os/THPsInThreadStackPreventionTest.java line 44:

> 42:  * @summary On THP=always systems, we prevent THPs from forming within thread stacks (negative test)
> 43:  * @library /test/lib
> 44:  * @requires vm.flagless

Not sure this is needed here as this is a manual test

test/hotspot/jtreg/runtime/os/TestTrimNative.java line 40:

> 38: /*
> 39:  * @test id=trimNativeStrict
> 40:  * @requires vm.flagless

Ditto perhaps not needed for a manual test

test/hotspot/jtreg/runtime/os/TestTrimNative.java line 76:

> 74:  * @test id=trimNativeLowIntervalStrict
> 75:  * @summary Very low (sub-second) interval, nothing should explode (stricter test, manual mode)
> 76:  * @requires vm.flagless

Ditto manual test

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15647#pullrequestreview-1621057042
PR Review Comment: https://git.openjdk.org/jdk/pull/15647#discussion_r1322233616
PR Review Comment: https://git.openjdk.org/jdk/pull/15647#discussion_r1322233897
PR Review Comment: https://git.openjdk.org/jdk/pull/15647#discussion_r1322234080


More information about the hotspot-runtime-dev mailing list