RFR: 8315739: Missing null check in os::vm_min_address [v2]

[David Holmes]

On Tue, 12 Sep 2023 05:29:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Changed, but I'm not sure if the result is more simple. I still need a proper check for `f != nullptr` before `fclose`.
>
> Ah! I missed that.

The existing code is overly complex. I think it can reduce to just:

if (f != nullptr) {
  fscanf(f, "%zu", &value);
  fclose(f);
}
value = MAX2(_vm_min_address_default, value);

though perhaps that makes an assumption that `value` is untouched if the conversion fails? I couldn't see anything definitive about that in the spec for it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15596#discussion_r1322414243