RFR: 8315739: Missing null check in os::vm_min_address [v2]

David Holmes dholmes at openjdk.org
Wed Sep 13 01:36:49 UTC 2023


On Tue, 12 Sep 2023 05:26:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this fix for handling of file `/proc/sys/vm/mmap_min_addr` which does not exist on WSL1.
>> 
>> This fixes a crash if the file is absent, and a file handle leak (missing `fclose`) when the file is present.
>> 
>> Linux tier1 tests clean.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move MAX after fclose

Looks fine. Thanks

Please note/remember hotspot changes need two reviews.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15596#pullrequestreview-1623497216


More information about the hotspot-runtime-dev mailing list