RFR: 8315739: Missing null check in os::vm_min_address [v2]
David Holmes
dholmes at openjdk.org
Wed Sep 13 01:36:50 UTC 2023
On Tue, 12 Sep 2023 09:22:02 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> I couldn't find any explicit statements in the spec either, but chances are good that it will just work. I'll make the change.
>
> well, it triggers a warning:
>
> warning: ignoring return value of 'int fscanf(FILE*, const char*, ...)', declared with attribute warn_unused_result [-Wunused-result]
>
> I'm not a big fan of suppressing warnings. Can we keep the current version?
Sure no problem.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15596#discussion_r1323820968
More information about the hotspot-runtime-dev
mailing list