RFR: 8310874: Runthese30m crashes with klass should be in the placeholders during verification

[Coleen Phillimore]

On Fri, 15 Sep 2023 00:17:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/classfile/loaderConstraints.cpp line 453:
>> 
>>> 451:   LoaderConstraint *p = find_loader_constraint(name, loader);
>>> 452:   if (p != nullptr && p->klass() != nullptr && p->klass() == klass) {
>>> 453:     log_info(class, loader, constraints)("removing klass %s failed to load", name->as_C_string());
>> 
>> Suggestion, either:
>> 
>> "removing klass %s: failed to load"
>> 
>> or
>> 
>> "removing klass %s as it failed to load"
>
> Actually "failed to load" seems rather vague here, the actual condition is much more specific isn't it?

The actual condition is in the pending exception and only in the case of OOM when calling addClass() in Java will we actually remove the entry.  I know this but the code is more general.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15752#discussion_r1326671997