RFR: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
Mikhailo Seledtsov
mseledtsov at openjdk.org
Fri Sep 15 18:23:15 UTC 2023
On Fri, 15 Sep 2023 17:58:43 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
> 8314830: runtime/ErrorHandling/ tests ignore external VM flags
Please review this change that adds @requires vm.flagless to most of the tests under test/hotspot/jtreg/runtime/ErrorHandling/.
The goal of these tests is to create a specific error condition and then to check the correctness of the error handling message. Each test uses carefully crafted command line to force specific error condition. Such tests do not intend to pass test JDK/JVM flags to child VM under test, therefore they should be marked with vm.flagless.
VeryEarlyAssertTest.java seems to be the only exception in this case - I have updated it to use ProcessTools method that passes JVM flags to child VM under test.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15767#issuecomment-1721671206
More information about the hotspot-runtime-dev
mailing list