RFR: 8310228: Improve error reporting for uncaught native exceptions on Windows [v3]

[Daniel Jeliński]

On Wed, 20 Sep 2023 19:40:46 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - use executeTestJvm to forward arguments
>>  - Merge branch 'master' into UncaughtExWin
>>  - address review comments
>>  - Merge branch 'master' into UncaughtExWin
>>  - remove uncaught exception string
>>  - Improve reporting of uncaught native exceptions
>>  - improve uncaught exception handling on Windows
>
> src/hotspot/os/windows/os_windows.cpp line 288:
> 
>> 286: #endif
>> 287: 
>> 288: LONG WINAPI Uncaught_Exception_Handler(struct _EXCEPTION_POINTERS* exceptionInfo);
> 
> can you make this method static?

the forward declaration (this line) should be static too, even if the VS compiler doesn't mind.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14523#discussion_r1332470449