RFR: 8316958: Add test for unstructured locking [v2]

David Holmes dholmes at openjdk.org
Thu Sep 28 04:17:24 UTC 2023


On Wed, 27 Sep 2023 13:19:20 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> In my original lightweight-locking PR, I had a testcase that exercises unstructured locking, which is permitted by the JVM spec, but not generated by javac, and thus not executed anywhere. JITs don't compile unstructured-locked code, therefore any code which attempts this would be slow anyway.
>> 
>> Testing:
>>  - [x] runtime/locking
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add Xcomp configuration; remove unneeded code

One nit but otherwise looks good.
Thanks

test/hotspot/jtreg/runtime/locking/TestUnstructuredLocking.jasm line 32:

> 30:  */
> 31: /*
> 32:  * @test id=Xcamp

typo: camp instead of comp

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15925#pullrequestreview-1647856211
PR Review Comment: https://git.openjdk.org/jdk/pull/15925#discussion_r1339499342


More information about the hotspot-runtime-dev mailing list