RFR: 8316958: Add test for unstructured locking [v3]

[Aleksey Shipilev]

On Thu, 28 Sep 2023 09:14:15 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> In my original lightweight-locking PR, I had a testcase that exercises unstructured locking, which is permitted by the JVM spec, but not generated by javac, and thus not executed anywhere. JITs don't compile unstructured-locked code, therefore any code which attempts this would be slow anyway.
>> 
>> Testing:
>>  - [x] runtime/locking
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test ID

Looks good to me, with minor nits.

(I am actually surprised one can make the pure jasm jtreg test, without any Java scaffolding, impressive.)

test/hotspot/jtreg/runtime/locking/TestUnstructuredLocking.jasm line 26:

> 24: 
> 25: /*
> 26:  * @test id=Xint

Might want to call it `int`; this is what we do elsewhere.

test/hotspot/jtreg/runtime/locking/TestUnstructuredLocking.jasm line 32:

> 30:  */
> 31: /*
> 32:  * @test id=Xcomp

Similarly, might want to call it `comp`.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15925#pullrequestreview-1650605794
PR Review Comment: https://git.openjdk.org/jdk/pull/15925#discussion_r1341257731
PR Review Comment: https://git.openjdk.org/jdk/pull/15925#discussion_r1341257936