RFR: 8328630: Add logging when needed symbols in dll are missing. [v3]

[Robbin Ehn]

On Tue, 2 Apr 2024 01:47:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   windows logging
>
> src/hotspot/os/windows/os_windows.cpp line 1289:
> 
>> 1287:     buf[end] = '\0';
>> 1288:   }
>> 1289:   return end;
> 
> This should have copied the explanatory comment as well. 
> 
> Pre-existing, but is  "./r/n" always added? If so the 'if' checks look weird - why would you not just set `buf[end-3] = '\0'` directly? If the formatting is actually variable this code will remove ".", "/r", "/n", "./r", "./n", "/r/n" and "./r/n". ???

Ok.

I have no clue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1547247056