RFR: 8323807: Async UL: Add a stalling mode to async UL [v2]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 2 10:36:07 UTC 2024


On Thu, 28 Mar 2024 07:03:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 41 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into ul-async-producer-consumer-take2
>>  - Missing N
>>  - Move constructors out of header file
>>  - Style
>>  - Correctly implement stalling
>>  - Missed one
>>  - Fix lossy conversions in tests
>>  - Merge remote-tracking branch 'origin/master' into ul-async-producer-consumer-take2
>>  - Only include sys/mman on Linux
>>  - Revert back to original Linux impl
>>  - ... and 31 more: https://git.openjdk.org/jdk/compare/e36a40a3...8c4ced0f
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 66:
> 
>> 64:   CircularStringBuffer::Message msg;
>> 65:   while (_circular_buffer.has_message()) {
>> 66:     CircularStringBuffer::DequeueResult result = _circular_buffer.dequeue(&msg, write_buffer, write_buffer_size);
> 
> Nit: is there any import/using/friend style directive we can use to avoid writing `CircularStringBuffer::DequeueResult` in full each time?

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17757#discussion_r1547589490


More information about the hotspot-runtime-dev mailing list