RFR: 8323807: Async UL: Add a stalling mode to async UL [v4]
Johan Sjölen
jsjolen at openjdk.org
Tue Apr 2 12:05:12 UTC 2024
> Hi,
>
> This PR does two things for the asynchronous UL mode:
>
> 1. Replaces the ping-pong buffers with a circular buffer.
> 2. Adds a `stall` mode to async UL, ensuring that no messages are ever dropped if the log message producers out pace the log message writing thread.
>
> These changes have been discussed on the hotspot-dev mailing list under the thread name "Request for Comment: Add a stalling mode to asynchronous UL". Xin Liu, the original author of the ping-pong approach, has confirmed that switching to circular buffers leads to a reduced rate of dropped messages.
>
> The ticket description and my original e-mail contain approximately the same information and I'd recommend that you read either of those if you want an overview of why these changes are made and what the high-level protocol is.
>
> All the best,
> Johan
Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
- Reflect renamings in tests
- Move more towards producer/consumer and fix alignment
- change to producer consumer in comment
- Rename to maybe_has_message
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17757/files
- new: https://git.openjdk.org/jdk/pull/17757/files/c51a679c..adda0ffc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17757&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17757&range=02-03
Stats: 20 lines in 4 files changed: 0 ins; 0 del; 20 mod
Patch: https://git.openjdk.org/jdk/pull/17757.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17757/head:pull/17757
PR: https://git.openjdk.org/jdk/pull/17757
More information about the hotspot-runtime-dev
mailing list