RFR: 8329470: Remove obsolete CDS SharedStrings tests

Calvin Cheung ccheung at openjdk.org
Tue Apr 2 16:49:09 UTC 2024


On Tue, 2 Apr 2024 03:27:14 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> These tests are quite time consuming. Removing them will speed up the CDS tests cycle.
> 
> [1] The LockSharedStrings.java test is obsolete. The archived strings used to be in its own "special" G1 region and we needed a test to check if locking objects in this region is working properly. Today all archived heap objects are stored in regular G1 regions. This test is no longer needed.
> 
> [2] During CDS dump time, we no longer allocate extra copies of the archived heap objects in the actual Java heap. So we can removed the portion of SharedStringsStress.java that tests for "an extra copy of these objects are allocated".

Looks good.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18573#pullrequestreview-1974393766


More information about the hotspot-runtime-dev mailing list