RFR: 8309751: Duplicate constant pool entries added during default method processing [v2]

[Coleen Phillimore]

On Tue, 2 Apr 2024 21:25:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added a comment and did some renaming to make it clearer what this is doing.
>
> src/hotspot/share/classfile/bytecodeAssembler.hpp line 77:
> 
>> 75:       u2 name_and_type_index;
>> 76:     } methodref;
>> 77:     uintptr_t value;
> 
> Now you have drawn attention to this by renaming it, what exactly is it? The rest of the union I can understand as they are different kinds of CP entries but what is a "value"??

Value is essentially (uintptr_t)utf8, or (uintptr_t)u2klass|u4name_and_type, or (uintptr_t)u2klass|u4methodref;  ie the value of the fields that are in the union.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18548#discussion_r1548671208