RFR: 8328630: Add logging when needed symbols in dll are missing. [v5]

[David Holmes]

On Wed, 3 Apr 2024 08:26:22 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider this additional logging.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use global namespace

One change needed but otherwise I like this duality. Thanks

src/hotspot/os/windows/os_windows.cpp line 1283:

> 1281: 
> 1282: void* os::dll_lookup(void *lib, const char *name) {
> 1283:   ::GetLastError(); // Clear old pending errors

There is nothing in the specification for `GetLastError` to indicate that it will clear the error itself. If you want to do this then you need to call `SetLastError(0)`.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18404#pullrequestreview-1976553187
PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1549579541