RFR: 8329651: TestLibGraal.java crashes with assert(_stack_base != nullptr)
Daniel D. Daugherty
dcubed at openjdk.org
Thu Apr 4 16:47:03 UTC 2024
On Thu, 4 Apr 2024 07:58:01 GMT, David Holmes <dholmes at openjdk.org> wrote:
> The first thing a new thread does is record its stack size and base. But it is made visible to the rest of the system prior to that. So we have a risk of trying to print information for a thread that may never have actually executed yet. `Thread::print_on_error` should access the `_stack_base` and `_stack_size` fields directly, not through the accessors with the assert.
>
> Testing:
> - tiers 1-3 (sanity)
>
> Thanks
Thumbs up. Thanks for including a comment to explain the weirdness.
-------------
Marked as reviewed by dcubed (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18615#pullrequestreview-1980546416
More information about the hotspot-runtime-dev
mailing list