RFR: JDK-8329663: hs_err file event log entry for thread adding/removing should print current thread [v2]

[Kevin Walls]

On Fri, 5 Apr 2024 08:12:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently the entries for adding / exiting threads look like this :
>> 
>> Event: 81.296 Thread 0x00007fd8300c13b0 Thread added: 0x00007fd8300c13b0
>> 
>> Event: 81.296 Thread 0x00007fd954000fe0 Thread exited: 0x00007fd954000fe0
>> 
>> The hex number describing the thread is printed twice, this should be simplified or the current thread AND and added/exited thread could be printed.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust info string for removed threads

I like logging Thread::current() rather than p - that corrects a logical error even if they are always the same (almost always the same?).

(Was there an effort to reduce calls to Thread::current ? There was JDK-8235629 but adding one to thread add/exit is not extreme!)

I don't see why the change of wording in the message though.  That seems disruptive with no benefit?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18627#pullrequestreview-1982552560