RFR: JDK-8329663: hs_err file event log entry for thread adding/removing should print current thread [v2]

Kevin Walls kevinw at openjdk.org
Fri Apr 5 11:38:01 UTC 2024


On Fri, 5 Apr 2024 10:47:49 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> > I don't see why the change of wording in the message though. That seems disruptive with no benefit?
> 
> Both wordings work for me; the method where we generate the event log entry is `Threads::remove` so I think the proposed remove is the better choice - David what do you think ?

Sure, don't mean drag things out or debate things unnecessarily, but changing a log message we have since at least jdk 1.4.2 should have some kind of justification (yes, it was in Threads::remove back then... 8-) )

In 1.4.2 it was just: Events::log("Thread exited: " INTPTR_FORMAT, p); ...somewhere in jdk7 or 8 the additional p was added, but enough archaeology. 8-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18627#issuecomment-2039578081


More information about the hotspot-runtime-dev mailing list