RFR: 8309751: Duplicate constant pool entries added during default method processing [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Apr 5 22:12:33 UTC 2024


On Tue, 2 Apr 2024 13:06:24 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This uses Ashutosh's patch to avoid adding duplicate constant pool entries during default method processing, with one change to make it conditional if not needed. I tested this locally and started writing a test, but writing a test is more difficult because duplicate constant pool entries don't actually violate the spec.
>> 
>> Tested with tier1-4 and ran some startup performance benchmarks on the patch.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added a comment and did some renaming to make it clearer what this is doing.

Thanks for reviewing, Matias.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18548#pullrequestreview-1984276198


More information about the hotspot-runtime-dev mailing list