RFR: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v3]

[Stefan Karlsson]

On Mon, 8 Apr 2024 09:24:33 GMT, Liming Liu <duke at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.hpp line 103:
>> 
>>> 101:     *major = _release_major;
>>> 102:     *minor = _release_minor;
>>> 103:   }
>> 
>> Do we really wan this function now, or could this be just plain getters?:
>> 
>> static long kernel_release_major() {
>>   return _kernel_release_major;
>> }
>> static long kernel_release_minor() {
>>   return _kernel_release_minor;
>> }
>
> systemMemoryBarrier_linux.cpp uses this function. If the interface was change here, the patch would involve some unrelated things.

Right. But you are changing the entire kernel_version() implementation and associated functions. Maybe that should be done as an initial, separate change then? Splitting this out into two RFE:s might make it easier to review as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18592#discussion_r1555522098