RFR: 8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved [v3]

Liming Liu duke at openjdk.org
Mon Apr 8 10:01:09 UTC 2024


On Mon, 8 Apr 2024 09:34:36 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> systemMemoryBarrier_linux.cpp uses this function. If the interface was changed here, the patch would involve some unrelated things.
>
> Right. But you are changing the entire kernel_version() implementation and associated functions. Maybe that should be done as an initial, separate change then? Splitting this out into two RFE:s might make it easier to review as well.

If it requires an initial change, I will prefer discussing the interface here. On the one hand, there is just one additional place to call the function, so the change would not be big. On the other hand, I'm not a author yet.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18592#discussion_r1555555415


More information about the hotspot-runtime-dev mailing list